Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Subrata Banik, Arthur Heymans, Patrick Rudolph, EricR Lai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55653 )
Change subject: soc/intel/common: Add cpu_fill_code_cache() to test eNEM ......................................................................
Patch Set 3:
(13 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55653/comment/ab9bfa76_0bd2d408 PS3, Line 12: could is
https://review.coreboot.org/c/coreboot/+/55653/comment/2d584691_9c906eb0 PS3, Line 19: TEST=Run this function on ADL-P RVP and don't see any hang. Please paste the new log lines.
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/55653/comment/57acf9eb_31ef0d41 PS3, Line 126: SOC_INTEL_CAR_DEBUG Stress test and debug are different things for me.
https://review.coreboot.org/c/coreboot/+/55653/comment/54b80d06_309ec3e7 PS3, Line 130: User to enable this Kconfig Please rephrase.
https://review.coreboot.org/c/coreboot/+/55653/comment/0d3e18b2_675b059e PS3, Line 131: region by filling up the cache by a memory copy. Please give more details like how much time this takes.
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/55653/comment/9aaf8235_743c477a PS3, Line 456: void If possible, please return CB_SUCCESS, ….
https://review.coreboot.org/c/coreboot/+/55653/comment/2fc5e4f3_7b913309 PS3, Line 477: return; Please print an error in this case.
https://review.coreboot.org/c/coreboot/+/55653/comment/55bc148e_c73a79bd PS3, Line 482: return; Can size_t be negative?
https://review.coreboot.org/c/coreboot/+/55653/comment/6f730f25_55e543d7 PS3, Line 485: alignment = 1UL << (log2_ceil(size)); Is the variable needed?
https://review.coreboot.org/c/coreboot/+/55653/comment/08088bad_0ab7b3cf PS3, Line 491: return; Please add a log message.
https://review.coreboot.org/c/coreboot/+/55653/comment/b7c4663d_e39e9276 PS3, Line 493: int unsigned int
https://review.coreboot.org/c/coreboot/+/55653/comment/e2118ac8_d2e61ef0 PS3, Line 493: i ++ i++
File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/55653/comment/323f8178_22146762 PS3, Line 173: cpu_fill_code_cache If it’s a stress test, it should be in the function name.