[M] Change in coreboot[master]: soc/intel/: Store ISH firmware version into cbmem table

[Sridhar Siricilla (Code Review)]

Attention is currently required from: Tarun Tuli, Dinesh Gehlot.

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 )

Change subject: soc/intel/: Store ISH firmware version into cbmem table
......................................................................

Patch Set 14:

(5 comments)

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/74208/comment/98e06fad_17c7fe5d 
PS14, Line 1278: FSP-M
memory?

https://review.coreboot.org/c/coreboot/+/74208/comment/f2cf1a5b_cbf0335f 
PS14, Line 1279: CSE DRAM 
DRAM.

CSE needs host memory access for ISH FW patching. Hence DRAM Init is prerequisite to get patched ISH firmware version.

https://review.coreboot.org/c/coreboot/+/74208/comment/27587c62_dcb086d1 
PS14, Line 1282: store_ish_version
Can we move this definition to new file?

https://review.coreboot.org/c/coreboot/+/74208/comment/0467ac30_eb6ad64d 
PS14, Line 1305: 			version->ish_partition_info.prev_cse_fw_version.major
               : 				= version->cur_cse_fw_version.major;
               : 			version->ish_partition_info.prev_cse_fw_version.minor
               : 				= version->cur_cse_fw_version.minor;
               : 			version->ish_partition_info.prev_cse_fw_version.hotfix
               : 				= version->cur_cse_fw_version.hotfix;
               : 			version->ish_partition_info.prev_cse_fw_version.build
               : 				= version->cur_cse_fw_version.build;
               : 
can you define generic function for copying the version from src to destination?
cse_copy_fw_version(struct fw_version *src, struct fw_version *dst)

https://review.coreboot.org/c/coreboot/+/74208/comment/2e7f8f16_00668a4e 
PS14, Line 1315: 			version->ish_partition_info.cur_ish_fw_version.major
               : 				= resp.manifest_data.version.major;
               : 			version->ish_partition_info.cur_ish_fw_version.minor
               : 				= resp.manifest_data.version.minor;
               : 			version->ish_partition_info.cur_ish_fw_version.hotfix
               : 				= resp.manifest_data.version.hotfix;
               : 			version->ish_partition_info.cur_ish_fw_version.build
               : 				= resp.manifest_data.version.build;
You may use generic version copy function (cse_copy_fw_version) for this as described above?