Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43261 )
Change subject: nb/amd/agesa/agesa_helper.h: Drop dead code ......................................................................
nb/amd/agesa/agesa_helper.h: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Icb98f3535f6c5f51081fc82262f6413f4b1a5733 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/amd/agesa/agesa_helper.h 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43261/1
diff --git a/src/northbridge/amd/agesa/agesa_helper.h b/src/northbridge/amd/agesa/agesa_helper.h index 8d229b1..120e74a 100644 --- a/src/northbridge/amd/agesa/agesa_helper.h +++ b/src/northbridge/amd/agesa/agesa_helper.h @@ -30,13 +30,8 @@
#define BSP_STACK_BASE_ADDR 0x30000
-#if 1 /* This covers node 0 only. */ #define HIGH_ROMSTAGE_STACK_SIZE (0x48000 - BSP_STACK_BASE_ADDR) -#else -/* This covers total of 8 nodes. */ -#define HIGH_ROMSTAGE_STACK_SIZE (0xA0000 - BSP_STACK_BASE_ADDR) -#endif
#define HIGH_MEMORY_SCRATCH 0x30000
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43261 )
Change subject: nb/amd/agesa/agesa_helper.h: Drop dead code ......................................................................
Patch Set 3: Code-Review+1
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43261 )
Change subject: nb/amd/agesa/agesa_helper.h: Drop dead code ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43261 )
Change subject: nb/amd/agesa/agesa_helper.h: Drop dead code ......................................................................
nb/amd/agesa/agesa_helper.h: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Icb98f3535f6c5f51081fc82262f6413f4b1a5733 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43261 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/amd/agesa/agesa_helper.h 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/northbridge/amd/agesa/agesa_helper.h b/src/northbridge/amd/agesa/agesa_helper.h index 8d229b1..120e74a 100644 --- a/src/northbridge/amd/agesa/agesa_helper.h +++ b/src/northbridge/amd/agesa/agesa_helper.h @@ -30,13 +30,8 @@
#define BSP_STACK_BASE_ADDR 0x30000
-#if 1 /* This covers node 0 only. */ #define HIGH_ROMSTAGE_STACK_SIZE (0x48000 - BSP_STACK_BASE_ADDR) -#else -/* This covers total of 8 nodes. */ -#define HIGH_ROMSTAGE_STACK_SIZE (0xA0000 - BSP_STACK_BASE_ADDR) -#endif
#define HIGH_MEMORY_SCRATCH 0x30000
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Michael Niewöhner (Code Review)