[M] Change in coreboot[main]: lib/jpeg: return string (not int) error messages - coreboot-gerrit

12 Sep 2024


      Attention is currently required from: Nigel Tao.
Nico Huber has posted comments on this change by Nigel Tao. ( https://review.coreboot.org/c/coreboot/+/84341?usp=email )
Change subject: lib/jpeg: return string (not int) error messages
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Patchset:
PS5: 
It feels uncommon to directly return a string in C (compared to `errno` and
similar). But I actually don't mind this in a cohesive environment, i.e. not
an API that is used all over the place.
File src/lib/jpeg.h:
https://review.coreboot.org/c/coreboot/+/84341/comment/428691e5_1dced40d?usp... :
PS5, Line 7: 
Should have a comment that `!= NULL` is an error.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84341?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I465a6eebc2a41ca9a618b1e86dee015cea40800b
Gerrit-Change-Number: 84341
Gerrit-PatchSet: 5
Gerrit-Owner: Nigel Tao nigeltao@golang.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nigel Tao nigeltao@golang.org
Gerrit-Comment-Date: Thu, 12 Sep 2024 20:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes