[XL] Change in coreboot[main]: soc/intel/ptl: Add GPIOs for Panther Lake SOC

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Elyes Haouas, Jamie Ryu, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra, Wonkyu Kim.

Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83789?usp=email )

Change subject: soc/intel/ptl: Add GPIOs for Panther Lake SOC
......................................................................

Patch Set 49:

(7 comments)

File src/soc/intel/pantherlake/include/soc/gpio_defs.h:

https://review.coreboot.org/c/coreboot/+/83789/comment/a3fa5a6b_54ec19d1?usp... :
PS49, Line 260: GPP_E_OFFSET
I don't see GPP_E0 in the EDS at offset 0x9a0. may be worth passing this feedback for EDS maintainer

https://review.coreboot.org/c/coreboot/+/83789/comment/7c7f131b_6142d7f6?usp... :
PS49, Line 261: GPP_CPUJTAG_OFFSET
do we need this macro?

File src/soc/intel/pantherlake/include/soc/gpio_soc_defs.h:

https://review.coreboot.org/c/coreboot/+/83789/comment/3bc5bf6d_6594c826?usp... :
PS49, Line 15: 0x1
INC(GPP_V)

https://review.coreboot.org/c/coreboot/+/83789/comment/8fb133c0_057f2891?usp... :
PS49, Line 31: 1
INC(GPP_COMM0_ID)

https://review.coreboot.org/c/coreboot/+/83789/comment/d4575783_78e5792d?usp... :
PS49, Line 36: #define GPP_COMM0_NAME "Community0"
             : #define GPP_COMM1_NAME "Community1"
             : #define GPP_COMM3_NAME "Community3"
             : #define GPP_COMM4_NAME "Community4"
             : #define GPP_COMM5_NAME "Community5"
             : 
             : #define GPP_V_NAME		"GPP_V"
             : #define GPP_C_NAME		"GPP_C"
             : #define GPP_F_NAME		"GPP_F"
             : #define GPP_E_NAME		"GPP_E"
             : #define GPP_CPUJTAG_NAME	"GPUJTAG"
             : #define GPP_H_NAME		"GPP_H"
             : #define GPP_A_NAME		"GPP_A"
             : #define GPP_VGPIO3_NAME		"vGPIO_3"
             : #define GPP_S_NAME		"GPP_S"
             : #define GPP_B_NAME		"GPP_B"
             : #define GPP_D_NAME		"GPP_D"
             : #define GPP_VGPIO_NAME		"vGPIO"
             : 
move macro definition into GPIO.h

https://review.coreboot.org/c/coreboot/+/83789/comment/96a32b5c_9462f4db?usp... :
PS49, Line 58: 1
INC(COMM_0)

https://review.coreboot.org/c/coreboot/+/83789/comment/4b1e3369_fa50aac1?usp... :
PS49, Line 250: #define NUM_COM1_GPP_GROUPS	2
I don't see any consumer for NUM_COMx_GPP_GROUPS macro