Attention is currently required from: Julius Werner, Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63068
to review the following change.
Change subject: soc/*: Use __fallthrough statement ......................................................................
soc/*: Use __fallthrough statement
Clang needs an attribute not a comment.
Change-Id: I78f87d80bd4f366ed6cfa74619dd107ac61bc935 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/nvidia/tegra210/bootblock.c M src/soc/rockchip/rk3288/display.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/63068/1
diff --git a/src/soc/nvidia/tegra210/bootblock.c b/src/soc/nvidia/tegra210/bootblock.c index 1657d7c..e8c4324 100644 --- a/src/soc/nvidia/tegra210/bootblock.c +++ b/src/soc/nvidia/tegra210/bootblock.c @@ -137,7 +137,7 @@ break; case OP_UDELAY: udelay(wa_op->val); - /* fall thru */ + __fallthrough; default: continue; } diff --git a/src/soc/rockchip/rk3288/display.c b/src/soc/rockchip/rk3288/display.c index 19a75de..9d6cca1 100644 --- a/src/soc/rockchip/rk3288/display.c +++ b/src/soc/rockchip/rk3288/display.c @@ -63,7 +63,7 @@ if (conf->vop_mode == VOP_MODE_EDP) return; } - /* fall thru */ + __fallthrough; case VOP_MODE_HDMI: printk(BIOS_DEBUG, "Attempting to setup HDMI display.\n"); rkclk_configure_hdmi(); @@ -78,7 +78,7 @@ if (conf->vop_mode == VOP_MODE_HDMI) return; } - /* fall thru */ + __fallthrough; default: printk(BIOS_WARNING, "Cannot read any edid info, aborting.\n"); return;