Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85578?usp=email )
Change subject: mb/trulo/var/uldrenite: Power management and external Settings
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85578/comment/cd6a6165_7c106cf1?usp... :
PS2, Line 7: Power management and external Settings
Please make it a statement. For example:
Add power management and external settings
or
Enable DPTF, S0ix and configure FIVR setting
https://review.coreboot.org/c/coreboot/+/85578/comment/61096cc8_5ed26b35?usp... :
PS2, Line 9: dptf
DPTF
https://review.coreboot.org/c/coreboot/+/85578/comment/b29d3d87_9bf971e9?usp... :
PS2, Line 10: s0ix
S0ix
https://review.coreboot.org/c/coreboot/+/85578/comment/da529fc6_c2797405?usp... :
PS2, Line 14: TEST=emerge-nissa coreboot
Do you have access to the device already?
File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85578/comment/1d5b5cd4_140991df?usp... :
PS2, Line 85: #DPTF
Add a space after #?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85578?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id7777b7560b40c1427df9645d991240c027e58e4
Gerrit-Change-Number: 85578
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sat, 14 Dec 2024 08:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No