Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Żygowski, Tim Crawford.
Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email )
Change subject: mb/novacustom: add V5x0TU board (Meteor Lake) ......................................................................
Patch Set 13:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82673/comment/f8a4db32_15ac420d?usp... : PS8, Line 28: - DDR5 SODIMM in slot RAM1
I've updated CB:52731 and uploaded CB:82733 for this.
Thanks, those patches did help
File src/mainboard/novacustom/mtl-h/romstage.c:
https://review.coreboot.org/c/coreboot/+/82673/comment/6d127381_ed5b46af?usp... : PS8, Line 23:
LpDdrDqDqsReTraining may sometimes help with training
Wasn't needed after all. There were 2 issues: - SPD reading, Tim's patches helped - I tested with different DIMMs that produced the same SPD checksum due to missing serial numbers, causing FSP to consider them the same and mistakenly try MRC fast boot instead of triggering retraining.
File src/mainboard/novacustom/mtl-h/vboot-rwab.fmd:
https://review.coreboot.org/c/coreboot/+/82673/comment/e2b4122e_dad7c314?usp... : PS8, Line 11: RW_FWID_A 64
64 bytes often occurs to be too small. […]
Done
https://review.coreboot.org/c/coreboot/+/82673/comment/b6342a27_89d0f5a5?usp... : PS8, Line 41: RO_GSCVD 8K
Do we need this?
Nope, removed
https://review.coreboot.org/c/coreboot/+/82673/comment/6e6df9a6_0fc53dea?usp... : PS8, Line 44: RO_FRID 64
a/a, use 256
Done