[XS] Change in coreboot[main]: FIXME remove asserts for mt8186 code - coreboot-gerrit

4 Sep 2024


      Attention is currently required from: Arthur Heymans, Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84208?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: FIXME remove asserts for mt8186 code
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84208/comment/8bb5353f_fb25e157?usp... :
PS2, Line 7: FIXME
Why this tag?
https://review.coreboot.org/c/coreboot/+/84208/comment/2e6ab2d5_671a076f?usp... :
PS2, Line 7: remove
Doesn't this patch "add" assertions?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84208?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6185e87a374f8722dba545d6bbce1c3a8de53e7e
Gerrit-Change-Number: 84208
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Wed, 04 Sep 2024 06:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No