Attention is currently required from: Nick Vaccaro, Ren Kuo, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84124?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox/jubilant: Update GPE0 routing ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84124/comment/7ed6b1b4_e67a990c?usp... : PS4, Line 25: register "pmc_gpe0_dw1" = "GPP_F" I am afraid this is going to break all the wake sources from EC - Lid Open, Key Press events, AC Connect/Disconnect etc. Did you check that?
Remember GPP_D0/D1 are where the EC interrupt and wake signals are routed to. It is unfortunate that the wake sources are routed to more than 3 GPP groups.
WLAN Wake -> GPP_B EC Wake -> GPP_D GSC, TCHPAD Wake -> GPP_E FP Wake -> GPP_F
We need to limit it to 3 GPIO groups.
-
Karthik Ramasubramanian (Code Review)