Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56007 )
Change subject: soc/intel/tigerlake: Switch to runtime generation of Intel Power Engine
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/56007/comment/eaa66b76_7544a9c3
PS3, Line 125: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_PEP))
Is this required?
THis is done this way to eventually move it to pmc common driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e97c589273e934e89d69d8829680b9cac1ff9f5
Gerrit-Change-Number: 56007
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 22:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment