Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42627 )
Change subject: soc/amd/stoneyridge: Correct ACPI CPU string prefix ......................................................................
soc/amd/stoneyridge: Correct ACPI CPU string prefix
Commit 9550e97 [acpi: correct the processor devices scope] changed the default CPU scope from _PR to _SB, but the default prefix in Stoneyridge's Kconfig was missed, leading to ACPI errors for 'AE_NOT_FOUND for object _PR.P00n.' Fix the default prefix and eliminate the errors reported in dmesg.
Test: boot Linux w/5.3 kernel on google/liara, check for errors
Change-Id: I5611b6836062a0a9f90036d7fe40cd98bd730af3 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/amd/stoneyridge/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/42627/1
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 47642a9..d8a3b34e 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -295,7 +295,7 @@
config ACPI_CPU_STRING string - default "\_PR.P%03d" + default "\_SB.P%03d"
config ACPI_BERT bool "Build ACPI BERT Table"
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42627 )
Change subject: soc/amd/stoneyridge: Correct ACPI CPU string prefix ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42627/1/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/42627/1/src/soc/amd/stoneyridge/Kco... PS1, Line 298: default "\_PR.P%03d" also correct "src/soc/amd/picasso/Kconfig" ?
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42627 )
Change subject: soc/amd/stoneyridge: Correct ACPI CPU string prefix ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42627/1/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/42627/1/src/soc/amd/stoneyridge/Kco... PS1, Line 298: default "\_PR.P%03d"
also correct "src/soc/amd/picasso/Kconfig" ?
picasso took a different approach to fixing and reverted in CB:41635 so don't believe it needs adjustment currently
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42627 )
Change subject: soc/amd/stoneyridge: Correct ACPI CPU string prefix ......................................................................
Patch Set 1: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42627 )
Change subject: soc/amd/stoneyridge: Correct ACPI CPU string prefix ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42627/1/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/42627/1/src/soc/amd/stoneyridge/Kco... PS1, Line 298: default "\_PR.P%03d"
picasso took a different approach to fixing and reverted in CB:41635 so don't believe it needs adjus […]
It's not broken on Picasso
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42627 )
Change subject: soc/amd/stoneyridge: Correct ACPI CPU string prefix ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42627 )
Change subject: soc/amd/stoneyridge: Correct ACPI CPU string prefix ......................................................................
soc/amd/stoneyridge: Correct ACPI CPU string prefix
Commit 9550e97 [acpi: correct the processor devices scope] changed the default CPU scope from _PR to _SB, but the default prefix in Stoneyridge's Kconfig was missed, leading to ACPI errors for 'AE_NOT_FOUND for object _PR.P00n.' Fix the default prefix and eliminate the errors reported in dmesg.
Test: boot Linux w/5.3 kernel on google/liara, check for errors
Change-Id: I5611b6836062a0a9f90036d7fe40cd98bd730af3 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42627 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/amd/stoneyridge/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 9bb5604..f093e28 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -296,7 +296,7 @@
config ACPI_CPU_STRING string - default "\_PR.P%03d" + default "\_SB.P%03d"
config ACPI_BERT bool "Build ACPI BERT Table"
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)