Attention is currently required from: Dinesh Gehlot, Emilie Roberts, Kapil Porwal, Nick Vaccaro.
Eric Lai has posted comments on this change by Emilie Roberts. ( https://review.coreboot.org/c/coreboot/+/83472?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Fix pmc_mux port in ec/google/chromeec for mithrax and felwinter
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83472/comment/943c2dcb_1a446c32?usp... :
PS3, Line 7: mb/google/brya: Fix pmc_mux port in ec/google/chromeec for mithrax and felwinter
nit: please shorten the title.
https://review.coreboot.org/c/coreboot/+/83472/comment/01dc4f51_5c7cc9dd?usp... :
PS3, Line 10: I349682a6fe3fe4848e4e86d9c446530a31b35875
nit:no need the full hash.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83472?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebd259842d3affa259069cd776b46759c1c60712
Gerrit-Change-Number: 83472
Gerrit-PatchSet: 3
Gerrit-Owner: Emilie Roberts
hadrosaur@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Emilie Roberts
hadrosaur@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 15 Jul 2024 13:39:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes