Attention is currently required from: Elyes Haouas, Felix Singer, Nico Huber.
Martin L Roth has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83347?usp=email )
Change subject: xcompile: Apply -Wextra with temporary exceptions to GCC
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Patchset:
PS3:
I would have done the opposite. […]
either way works for me there are trade-offs to either. it sounds like Felix is willing to deal with new warnings that come in with new compiler versions, so I'm fine with this approach. if it becomes an issue in the future, we can reverse things at that point.
hopefully that works for everyone.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83347?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60915cb66581dc2c9b6807335fd0e214b45e76d6
Gerrit-Change-Number: 83347
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 10 Jul 2024 04:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr