Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 )
Change subject: console: Add loglevel prefix to interactive consoles ......................................................................
Patch Set 3:
(3 comments)
File src/commonlib/include/commonlib/loglevel.h:
https://review.coreboot.org/c/coreboot/+/61306/comment/74eef163_8b474aa1 PS3, Line 170: EMERG Maybe we can add color codes too!
I use the following in my local workspace: https://review.coreboot.org/c/coreboot/+/61575
File src/console/console.c:
https://review.coreboot.org/c/coreboot/+/61306/comment/b13fcdf0_dcb11c63 PS3, Line 27: line_start Let's move this function into printk.c (wrap_putchar). Then we don't need to pass around the `console_last_loglevel` via a global variable. I think it also makes sense to keep `console_tx_byte` simple.
https://review.coreboot.org/c/coreboot/+/61306/comment/82a4e646_c173d656 PS3, Line 60: 0 nit: false
-
Raul Rangel (Code Review)