Attention is currently required from: Bao Zheng, Zheng Bao.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72959 )
Change subject: amdfwtool: Support flash size 32M ......................................................................
Patch Set 4: Code-Review-1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/72959/comment/5e27d3ec_b89dbc5d PS4, Line 2363: rom_base_address = 0xFFFFFFFF - ctx.rom_size + 1; At most 16M gets mapped. which part of 32 or 64M flash is configurable. Comparing the efs and body location is just confusing. Can't just use which 16M part of a flash you want as location for body and efs as an input instead of using weird and incorrect memory mapping semantics?