Felix Held has posted comments on this change by Jędrzej Ciupis. ( https://review.coreboot.org/c/coreboot/+/83884?usp=email )
Change subject: soc/intel/jasperlake: Add CrashLog implementation for Intel JSL
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/jasperlake/crashlog_lib.c:
PS2:
Thanks for the comment, it's a fair point. I considered reworking the code when preparing the patch. […]
sure, i'm fine with keeping it as it is right now, which is why i had my comment marked as resolved and submitted the patch. so that was just a suggestion
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83884?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia18a79d8de849d556b4b8fd0e6b43090311eb23f
Gerrit-Change-Number: 83884
Gerrit-PatchSet: 3
Gerrit-Owner: Jędrzej Ciupis
jciupis@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Aug 2024 14:31:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jędrzej Ciupis
jciupis@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de