Attention is currently required from: Angel Pons, Dinesh Gehlot, Jayvik Desai, Julius Werner, Paul Menzel.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )
Change subject: vc/google/chromeos: Enable eSOL config with libgfx and uGOP ......................................................................
Patch Set 23: -Code-Review
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83705/comment/88695a69_138e0f27?usp... : PS20, Line 105: config CHROMEOS_ENABLE_ESOL
So are you saying that the Kconfig only exists so that you can extract the `config` file from CBFS and check for it? I guess that's fine, but it is a very unusual use of Kconfig so you should definitely explain that in the `help` text here. If you just create an unused Kconfig and don't explain why you need it someone might go and delete it again.
valid point and adding a meaningful help text is always desirable. But with https://review.coreboot.org/c/coreboot/+/83769/comment/35b91b25_aaf1754c/ suggested changes, I believe this Kconfig is no more a unused Kconfig even in coreboot space.
also, you could change below code to use newly added Kconfig https://github.com/coreboot/coreboot/blob/main/src/soc/intel/alderlake/romst...
``` if (!CONFIG(CHROMEOS_ENABLE_ESOL) || !early_graphics_init()) { timestamp_add_now(TS_ESOL_END); return false; }
```