Attention is currently required from: Chen Wisley, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Subrata Banik.
Wisley Chen has posted comments on this change by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/83291?usp=email )
Change subject: mb/google/nissa/var/domika: Create a domika variant
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83291/comment/0e3b19dc_79ec04a9?usp... :
PS3, Line 9: Twinlake
Twin Lake
Done
https://review.coreboot.org/c/coreboot/+/83291/comment/23b6b03d_cbf6f37c?usp... :
PS3, Line 11: Twinlake
Twin Lake
Done
https://review.coreboot.org/c/coreboot/+/83291/comment/294de60c_7b9ea8e0?usp... :
PS3, Line 9: This patch creates a new domika variant which is a Twinlake
: platform. This variant uses Yavilla board mounted with the
: Twinlake SOC and hence the plan is to reuse the existing
: yavilla code.
Please try to use 72 characters per line.
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/83291/comment/9a6dc1a3_19ecce86?usp... :
PS3, Line 235: select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG
order please
Done
https://review.coreboot.org/c/coreboot/+/83291/comment/1cd1bb81_999f7c29?usp... :
PS3, Line 236: select CHROMEOS_WIFI_SAR if CHROMEOS
order please?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83291?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719
Gerrit-Change-Number: 83291
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 00:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org