Change in coreboot[master]: soc/intel/common/block/pcie/rtd3: Add PM methods to the device.

Feb. 1, 2022
1:26 a.m.
Attention is currently required from: Lance Zhao, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta, Patrick Rudolph. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61352 ) Change subject: soc/intel/common/block/pcie/rtd3: Add PM methods to the device. ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/pcie/rtd3/chip.h: https://review.coreboot.org/c/coreboot/+/61352/comment/9140d373_65890f7f PS1, Line 53: ext_pm_support > Done Tim, ex_pm_support has been changed to use 'enum' type. - enum type is added in the chip.h - ex_pm_support is also checked if the methods to request are available or not. - rtd3 device is also referenced to get its config for this field in the device. - device calls the exported methods based on ex_pm_support enum. Please also see the other reviews: https://review.coreboot.org/c/coreboot/+/61354 https://review.coreboot.org/c/coreboot/+/61355 -- To view, visit https://review.coreboot.org/c/coreboot/+/61352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79de76f26c8424b036cb7d2719df68937599ca2f Gerrit-Change-Number: 61352 Gerrit-PatchSet: 5 Gerrit-Owner: Cliff Huang <cliff.huang@intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta@intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Lance Zhao Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Anil Kumar K <anil.kumar.k@intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid@intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta@intel.com> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Comment-Date: Tue, 01 Feb 2022 00:26:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lance Zhao Comment-In-Reply-To: Cliff Huang <cliff.huang@intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-MessageType: comment
1262
Age (days ago)
1262
Last active (days ago)
0 comments
1 participants
participants (1)
-
Cliff Huang (Code Review)