Change in ...coreboot[master]: mb/lenovo/x1_carbon_gen1/acpi: call MUTE(1) and USBP(0) on _PTS
Nicola Corna has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31829
Change subject: mb/lenovo/x1_carbon_gen1/acpi: call MUTE(1) and USBP(0) on _PTS ......................................................................
mb/lenovo/x1_carbon_gen1/acpi: call MUTE(1) and USBP(0) on _PTS
Like with any other Thinkpad, call MUTE(1) and USBP(0) on _PTS on the Lenovo Thinkpad X1 Carbon 1st generation. Without MUTE(1) the speakers sometimes glitch before going into S3 (if not muted), while without USBP(0) the USB ports are always powered in S3, regardless of the USB Always-On mode selected.
Change-Id: I86f3c5a72e2589c5570303bf68f39df3ef874cb8 Signed-off-by: Nicola Corna nicola@corna.info --- M src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31829/1
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl index b63c91c..bf686f4 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl @@ -19,6 +19,8 @@
Method(_PTS,1) { + _SB.PCI0.LPCB.EC.MUTE(1) + _SB.PCI0.LPCB.EC.USBP(0) _SB.PCI0.LPCB.EC.RADI(0) }
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31829 )
Change subject: mb/lenovo/x1_carbon_gen1/acpi: call MUTE(1) and USBP(0) on _PTS ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31829 )
Change subject: mb/lenovo/x1_carbon_gen1/acpi: call MUTE(1) and USBP(0) on _PTS ......................................................................
mb/lenovo/x1_carbon_gen1/acpi: call MUTE(1) and USBP(0) on _PTS
Like with any other Thinkpad, call MUTE(1) and USBP(0) on _PTS on the Lenovo Thinkpad X1 Carbon 1st generation. Without MUTE(1) the speakers sometimes glitch before going into S3 (if not muted), while without USBP(0) the USB ports are always powered in S3, regardless of the USB Always-On mode selected.
Change-Id: I86f3c5a72e2589c5570303bf68f39df3ef874cb8 Signed-off-by: Nicola Corna nicola@corna.info Reviewed-on: https://review.coreboot.org/c/coreboot/+/31829 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl index b63c91c..bf686f4 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl @@ -19,6 +19,8 @@
Method(_PTS,1) { + _SB.PCI0.LPCB.EC.MUTE(1) + _SB.PCI0.LPCB.EC.USBP(0) _SB.PCI0.LPCB.EC.RADI(0) }
-
Nicola Corna (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)