Attention is currently required from: Angel Pons.
Hello Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/83599?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Angel Pons
Change subject: gma: Re-structure TC port types ......................................................................
gma: Re-structure TC port types
The `USBC1_DP/_HDMI' names did not draw an accurate picture. If they are implemented as legacy ports (for HDMI always the case), they don't show as USBC in schematics, the OS or anywhere else. We also couldn't tell if a `USBCx_DP' was implemented as legacy or USB-C.
We split them by actual, physical connector type now: HDMI, DP, and USBC (for DP-Alt mode). The `_TCx' suffixes should provide an idea where they are connected to a socket or SoC.
Tiger Lake and seemingly Alder Lake use the first 4 TC register sets only. Hence we keep only 4 respective TC ports for now.
Also, as any of the 3 Combo-PHYs (DP1..3) can be used as eDP, we map that to the port, that is used with the first set of panel- control lines. This should hopefully match most board designs.
Change-Id: If9755fe8e1f9252e6e77e22fe910964ad3c3743b Signed-off-by: Nico Huber nico.huber@secunet.com --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads M configs/tigerlake 5 files changed, 76 insertions(+), 75 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/99/83599/2