[L] Change in coreboot[main]: mb/erying: Add Erying Polestar G613 Pro (TGL-H)

[Alicja Michalska (Code Review)]

Attention is currently required from: Angel Pons, Felix Singer, Maxim, Michał Kopeć, Michał Żygowski, Nicholas Chin, Paul Menzel.

Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/80853?usp=email )

Change subject: mb/erying: Add Erying Polestar G613 Pro (TGL-H)
......................................................................

Patch Set 12:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/80853/comment/cc385d4c_b6de5ca6?usp... :
PS8, Line 31: - Automatic fan control (IT8613E can't read CPU_TIN at the moment)
> Given my issues with the IT8613E on the ODROID-H4, figuring this one out won't be as easy

Yup, we'd need access to IT8613E datasheet for it.

File src/mainboard/erying/tgl/Kconfig:

https://review.coreboot.org/c/coreboot/+/80853/comment/2f27958a_2e70b277?usp... :
PS12, Line 14: 	select HAVE_ACPI_RESUME
> If S3 resume is broken, I would comment out this line

Acknowledged

File src/mainboard/erying/tgl/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/80853/comment/3c32a1bd_e569dbb4?usp... :
PS12, Line 27: Scope (_SB.PCI0.LPCB)
             : 	{
             : 	}
> Still here from PS8

Done

File src/mainboard/erying/tgl/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/80853/comment/e5311f62_c6ce743b?usp... :
PS12, Line 26: #if (!CONFIG_SOC_INTEL_DISABLE_IGD)
             : 		/* Tigerlake HDMI */
             : 		0x80862812, /* Vendor ID */
             : 		0x80860101, /* Subsystem ID */
             : 		2, /* Number of entries */
             : 		AZALIA_SUBVENDOR(2, 0x80860101),
             : 		AZALIA_PIN_CFG(2, 0x04, 0x18560010),
             : 	#endif
> We don't indent preprocessor in coreboot: […]

Wasn't sure, didn't feel right. Thanks!

File src/mainboard/erying/tgl/romstage_fsp_params.c:

https://review.coreboot.org/c/coreboot/+/80853/comment/d02022f8_5896b44a?usp... :
PS8, Line 25: mupd->FspmConfig.OcSupport = 1;
            : 	mupd->FspmConfig.OcLock = 0;
> OcSupport may be needed for XMP to be used, OcLock might be to allow changing settings at runtime so […]

I've tested it. OcSupport/OcLock isn't necessary for XMP to work after all

https://review.coreboot.org/c/coreboot/+/80853/comment/5f74ec6a_9d1d38f8?usp... :
PS8, Line 43: 	mupd->FspmConfig.DmiMaxLinkSpeed = 3;
> Interesting... […]

Indeed it is, lol