Attention is currently required from: Hung-Te Lin, Xixi Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 )
Change subject: src/mediatek/mt8186: Implement sdram_size() to get real dram size
......................................................................
Patch Set 20: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62065/comment/1bf156a6_ad33ee3e
PS20, Line 9: set to 4GB by default
hard-coded to 4GB
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/e3af3768_43dbdb94
PS20, Line 28: channel = (void *)((uintptr_t)mc + sizeof(*mc));
Please fix this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I017e9d1a2d6e26f1fc21b67b5962dfb5c6ade8a5
Gerrit-Change-Number: 62065
Gerrit-PatchSet: 20
Gerrit-Owner: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 21 Mar 2022 09:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment