Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/4717496b_adf7ecd3?usp... :
PS5, Line 38: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) {
: printk(BIOS_DEBUG, "Configure MAX98390 audio\n");
:
: mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST);
: configure_i2s();
: } else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
: printk(BIOS_DEBUG, "Configure TAS2563 audio\n");
: mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST);
: configure_i2s();
: }
There is relevant printing information, I has been modified.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 7
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 09:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com