Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68753 )
Change subject: mb/google/reef: Fix guarding of reading SKU from VPD ......................................................................
mb/google/reef: Fix guarding of reading SKU from VPD
VPD read depends on CONFIG(VPD), not CONFIG(CHROMEOS).
TEST=build/boot snappy, verify SKU set properly in SMBIOS
Change-Id: I8aa57f793bd04dbe31f3b49bbff23e05c96592a6 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/68753 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/reef/variants/snappy/mainboard.c 1 file changed, 18 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c index fc0652c..0b15505 100644 --- a/src/mainboard/google/reef/variants/snappy/mainboard.c +++ b/src/mainboard/google/reef/variants/snappy/mainboard.c @@ -43,7 +43,7 @@
board_sku_num = sku_strapping_value();
- if (!CONFIG(CHROMEOS)) + if (!CONFIG(VPD)) return board_sku_num;
if (!vpd_gets(vpd_skuid, vpd_buffer, ARRAY_SIZE(vpd_buffer), VPD_RO_THEN_RW))