Change in coreboot[master]: intel/common/../systemagent: Add sa_get_mchbar_base api - coreboot-gerrit

21 Apr 2022


      Attention is currently required from: Wonkyu Kim, Tim Wawrzynczak, Paul Menzel, Michael Niewöhner.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 )
Change subject: intel/common/../systemagent: Add sa_get_mchbar_base api
......................................................................
Patch Set 11:
(2 comments)
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/63615/comment/ecbe7bd9_8becf497 
PS11, Line 89: if(mchbar_lo & 0x1) 
one space between if and brace ?
https://review.coreboot.org/c/coreboot/+/63615/comment/d46fc664_54b7b189 
PS11, Line 94: if(mchbar_base == 0) {
one space between if and brace ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63615
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c7af3ea8c2b2b6afcc76e1165fadbe15e0bceb
Gerrit-Change-Number: 63615
Gerrit-PatchSet: 11
Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 21 Apr 2022 04:49:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment