Attention is currently required from: Arthur Heymans, Tristan Corrick, Angel Pons, Alexander Couzens, Patrick Rudolph.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59314 )
Change subject: cpu/haswell/*.c: Use static.c exposed lapic 0
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/auron/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59314/comment/3c3df598_86084a19
PS2, Line 20: device lapic 0xacac off end
you would then have two isolated chips in the devicetree, which doesn't make sense. It would no longer be a device tree!
Is that really a problem though? A `chip` is a logical construct for configuring multiple devices with the same settings. The `cpu_cluster` and the `domain` are already children of the root node. i.e., They are siblings. So from the device hierarchy perspective, there is no change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic449b2df8036e8c02b5559cca6b2e7479a70a786
Gerrit-Change-Number: 59314
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Nov 2021 17:32:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment