Attention is currently required from: Angel Pons, Felix Singer, Frans Hendriks, Jeremy Soller, Michał Żygowski, Nico Huber, Piotr Król, Sean Rhodes, Tim Crawford.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75888?usp=email )
Change subject: mb/{skl,kbl}: Use true/false keywords for non-array dt options
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75888/comment/aa4db14d_5b88182b :
PS5, Line 25: soc_gen="skylake" && \
: options=`grep -A 1337 -r "struct soc_intel_${soc_gen}_config" "src/soc/intel/${soc_gen}/chip.h" | \
: grep "bool" | \
: cut -d ';' -f 1 | \
: tr '\t' ' ' | \
: cut -d ' ' -f 3 | \
: sed -E 's/[a-zA-Z0-9_]+[.+]//g'`
: devicetrees=`find "src/mainboard" -name '*.cb' \
: -exec grep -H "chip soc/intel/${soc_gen}" {} ; | \
: cut -d ':' -f 1` && \
: for option in ${options}; do \
: echo ${devicetrees} | \
: xargs sed -i'' -E \
: -e "s/"${option}"(\s+)=(\s+)"1"/${option}\1=\2true/g" \
: -e "s/"${option}"(\s+)=(\s+)"0"/${option}\1=\2false/g"; \
: done
:
I would modify the script like this: […]
opinions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff063c37a093e597c6b73a583903ce5e4f698856
Gerrit-Change-Number: 75888
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 14:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment