Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42909 )
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.
Change-Id: I3061a3a8188c020ee7ca31bcddccbd16f31761e4 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42909/1
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 9e5ef4b..6a4b875 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -88,5 +88,49 @@ end end end # PMC + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| chipset_lockdown | CHIPSET_LOCKDOWN_COREBOOT | + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| GSPI1 | Fingerprint MCU | + #| I2C0 | Audio | + #| I2C1 | Touchscreen | + #| I2C2 | WLAN, SAR0 | + #| I2C3 | Camera, SAR1 | + #| I2C5 | Trackpad | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 163, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, + }" end end
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42909
to look at the new patch set (#2).
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.
Change-Id: I3061a3a8188c020ee7ca31bcddccbd16f31761e4 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42909/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42909
to look at the new patch set (#3).
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726
Change-Id: I3061a3a8188c020ee7ca31bcddccbd16f31761e4 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42909/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42909
to look at the new patch set (#4).
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.
Change-Id: I3061a3a8188c020ee7ca31bcddccbd16f31761e4 Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42909/4
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42909
to look at the new patch set (#5).
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz.
BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz.
Change-Id: I3061a3a8188c020ee7ca31bcddccbd16f31761e4 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42909/5
Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42909 )
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ......................................................................
Abandoned
-
Johnny Li (Code Review)