Change in coreboot[master]: mb/google/brya: set GPP_D0 to GPO and unlocked - coreboot-gerrit

14 Mar 2022


      Attention is currently required from: YH Lin, Nick Vaccaro, Eric Lai, Wisley Chen, Mark Hsieh, EricR Lai, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62739 )
Change subject: mb/google/brya: set GPP_D0 to GPO and unlocked
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brya/gpio.c:
https://review.coreboot.org/c/coreboot/+/62739/comment/639d697a_eba7d2d0 
PS4, Line 121: PAD_CFG_GPO
...
looks like it worked with GPO_LOCK, please update the CL.
Oh yes flash_fp_mcu is setting the MODE bits to OUTPUT, so it needs to be set explicitly here
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I164ffff6bd3b4058d6e28247eb7c3ed46d3891b5
Gerrit-Change-Number: 62739
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anfernee Chen anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: YH Lin yueherngl@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 14 Mar 2022 14:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment