Attention is currently required from: Felix Singer, Henry Sun, Tarun Tuli, Yunlong Jia.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76013?usp=email )
Change subject: mb/google/nissa/var/gothrax: Initialise overridetree
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76013/comment/0c903bc5_f711a0ff :
PS2, Line 35: register "ext_fivr_settings" = "{
: .configure_ext_fivr = 1,
: .v1p05_enable_bitmap = FIVR_ENABLE_ALL_SX & ~FIVR_ENABLE_S0,
: .vnn_enable_bitmap = FIVR_ENABLE_ALL_SX,
: .vnn_sx_enable_bitmap = FIVR_ENABLE_ALL_SX,
: .v1p05_supported_voltage_bitmap = FIVR_VOLTAGE_NORMAL,
: .vnn_supported_voltage_bitmap = FIVR_VOLTAGE_MIN_ACTIVE,
: .v1p05_voltage_mv = 1050,
: .vnn_voltage_mv = 780,
: .vnn_sx_voltage_mv = 1050,
: .v1p05_icc_max_ma = 500,
: .vnn_icc_max_ma = 500,
: }"
missing tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76013?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfd9788a75f9c342f85d6e1a3d54327d64797dd8
Gerrit-Change-Number: 76013
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 09:15:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment