Change in coreboot[master]: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end comm...

[Philipp Deppenwiese (Code Review)]

Hello build bot (Jenkins), Jonathan Zhang, Ryback Hung, Paul Menzel, Angel Pons, Rocky Phagura, Bryant Ou, Patrick Rudolph, Tim Chu,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/43069

to review the following change.

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"

This reverts commit a5ca4a0c75237093f1a4d90f30c0c932e5fcd05d.

Reason for revert: Bricks coreboot tree because of non existent kconfig symbol

Change-Id: Ib8f55dc2f6444690945bc2dc64baad5d0c39cdf4
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43069/1

diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig
index 8b45689..b4e88b5 100644
--- a/src/mainboard/ocp/deltalake/Kconfig
+++ b/src/mainboard/ocp/deltalake/Kconfig
@@ -10,7 +10,6 @@
    select SUPERIO_ASPEED_AST2400
    select IPMI_KCS
    select IPMI_KCS_ROMSTAGE
-	select IPMI_OCP
    select OCP_DMI
    select VPD
    select VPD_SMBIOS_VERSION
diff --git a/src/mainboard/ocp/deltalake/devicetree.cb b/src/mainboard/ocp/deltalake/devicetree.cb
index 122f4ff..cc17e06 100644
--- a/src/mainboard/ocp/deltalake/devicetree.cb
+++ b/src/mainboard/ocp/deltalake/devicetree.cb
@@ -85,9 +85,6 @@
    			register "bmc_i2c_address" = "0x20"
    			register "bmc_boot_timeout" = "60"
    		end
-			chip drivers/ocp/ipmi # OCP specific IPMI porting
-				device pnp ca2.1 on end
-			end
    	end # ISA bridge: Intel Device a245
    	device pci 1f.1 on end # p2sb
    	device pci 1f.2 on end # Memory controller: Intel Device a221

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43069 )

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43069 )

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Patch Set 1: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/43069/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43069/1//COMMIT_MSG@11 
PS1, Line 11: Bricks
Breaks

https://review.coreboot.org/c/coreboot/+/43069/1//COMMIT_MSG@14 
PS1, Line 14: 
Missing sign-off

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43069 )

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Abandoned

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has restored this change. ( https://review.coreboot.org/c/coreboot/+/43069 )

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Restored

[Philipp Deppenwiese (Code Review)]

Hello build bot (Jenkins), Jonathan Zhang, Ryback Hung, Paul Menzel, Angel Pons, Rocky Phagura, Bryant Ou, Patrick Rudolph, Tim Chu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43069

to look at the new patch set (#2).

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"

This reverts commit a5ca4a0c75237093f1a4d90f30c0c932e5fcd05d.

Reason for revert: Breaks coreboot tree because of non existent kconfig symbol

Change-Id: Ib8f55dc2f6444690945bc2dc64baad5d0c39cdf4
Signed-off-by: Philipp Deppenwiese 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43069/2

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43069 )

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43069/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43069/1//COMMIT_MSG@11 
PS1, Line 11: Bricks
> Breaks

Done

https://review.coreboot.org/c/coreboot/+/43069/1//COMMIT_MSG@14 
PS1, Line 14:
> Missing sign-off

Done

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43069 )

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"

This reverts commit a5ca4a0c75237093f1a4d90f30c0c932e5fcd05d.

Reason for revert: Breaks coreboot tree because of non existent kconfig symbol

Change-Id: Ib8f55dc2f6444690945bc2dc64baad5d0c39cdf4
Signed-off-by: Philipp Deppenwiese 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43069
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/mainboard/ocp/deltalake/Kconfig
M src/mainboard/ocp/deltalake/devicetree.cb
2 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig
index 8b45689..b4e88b5 100644
--- a/src/mainboard/ocp/deltalake/Kconfig
+++ b/src/mainboard/ocp/deltalake/Kconfig
@@ -10,7 +10,6 @@
    select SUPERIO_ASPEED_AST2400
    select IPMI_KCS
    select IPMI_KCS_ROMSTAGE
-	select IPMI_OCP
    select OCP_DMI
    select VPD
    select VPD_SMBIOS_VERSION
diff --git a/src/mainboard/ocp/deltalake/devicetree.cb b/src/mainboard/ocp/deltalake/devicetree.cb
index 122f4ff..cc17e06 100644
--- a/src/mainboard/ocp/deltalake/devicetree.cb
+++ b/src/mainboard/ocp/deltalake/devicetree.cb
@@ -85,9 +85,6 @@
    			register "bmc_i2c_address" = "0x20"
    			register "bmc_boot_timeout" = "60"
    		end
-			chip drivers/ocp/ipmi # OCP specific IPMI porting
-				device pnp ca2.1 on end
-			end
    	end # ISA bridge: Intel Device a245
    	device pci 1f.1 on end # p2sb
    	device pci 1f.2 on end # Memory controller: Intel Device a221

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43069 )

Change subject: Revert "mb/ocp/deltalake: Select IPMI OCP to send POST start/end command"
......................................................................

Patch Set 3: Code-Review+1