Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Rex-BC Chen, Angel Pons, Yu-Ping Wu.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62359 )
Change subject: soc/mediatek: PCIe: Assert PERST# at bootblock stage
......................................................................
Patch Set 19:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62359/comment/b27be47a_9a0becae
PS18, Line 32:
Please add […]
Done
File src/soc/mediatek/mt8195/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/62359/comment/0e231339_e1842d98
PS18, Line 11: bootblock-$(CONFIG_PCI) += pcie.c
This could be a separate commit.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b9369e6f8599f93415588ea585c952a41c5e7d
Gerrit-Change-Number: 62359
Gerrit-PatchSet: 19
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 09:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment