Attention is currently required from: Eric Lai, Kane Chen, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )
Change subject: soc/intel/meteorlake: Add support for crashlog
......................................................................
Patch Set 23:
(1 comment)
File src/soc/intel/meteorlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/74769/comment/c537a62a_9d823e37 :
PS23, Line 14: static bool m_pmc_crashLog_support;
Better create a struct for support,present,size ;) […]
Yes, agree. After adding new SOC support and many other changes it's time to refactor this code. Let's get this code merged to enable MTL, then i will fix the code with more optimization with separate CLs. Marking this comment as resolved for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0abd697fba35edf1c03d2a3a325b7785b985cd5
Gerrit-Change-Number: 74769
Gerrit-PatchSet: 23
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 17:21:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment