Attention is currently required from: Martin L Roth, Martin Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71673 )
Change subject: Kconfig: Add option to compress ramstage with LZ4 ......................................................................
Patch Set 1:
(4 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/71673/comment/cc924098_27e5c7f0 PS1, Line 173: config MB_COMPRESS_RAMSTAGE_LZ4 I wonder if this should be a variable affecting both payload compression and ramstage compression, because if LZ4 is better for one of them it would likely be better for the other as well? It could be a sort of generic PREFER_LZ4 option that affects all compression choices.
https://review.coreboot.org/c/coreboot/+/71673/comment/b18bd944_6463e019 PS1, Line 180: depends on HAVE_RAMSTAGE && !UNCOMPRESSED_RAMSTAGE I forget, what actually happens when the depends on in a choice is not satisfied? Does that mean both of the choice options will be set to false? I thought one of the choice options always has to be true but maybe I misremember that case...
https://review.coreboot.org/c/coreboot/+/71673/comment/f01a6a49_f1250ed9 PS1, Line 181: default COMPRESS_RAMSTAGE_LZ4 if MB_COMPRESS_RAMSTAGE_LZ4 Don't you still need a `default COMPRESS_RAMSTAGE_LZMA` after this as well?
https://review.coreboot.org/c/coreboot/+/71673/comment/bb004cce_51c79cf2 PS1, Line 192: Compress ramstage with LZ4 for faster decompression It would be good to explain the trade-offs involved in this decision (e.g. flash reading speed vs CPU speed and flash space) in more detail in one of these help strings.
-
Julius Werner (Code Review)