[S] Change in coreboot[master]: commonlib...cbmem_id.h: Add AMD STB buffer IDs for CBMEM - coreboot-gerrit

28 Oct 2022


      Attention is currently required from: Martin L Roth.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68926 )
Change subject: commonlib...cbmem_id.h: Add AMD STB buffer IDs for CBMEM
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/68926/comment/b929013e_2c6de610 
PS1, Line 164: 	{ CBMEM_ID_AMD_STB,		"AMD MP2 BUFFER"}
nit: Should this have a blank line before the #endif?
nit: Would it break anything if there is a comma at the end of this line?  That way fewer lines would change in the future when more IDs are added.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68926
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27157ad65df992bcdd0e0d15a6d01b96e24067c0
Gerrit-Change-Number: 68926
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Comment-Date: Fri, 28 Oct 2022 20:15:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment