Change in coreboot[master]: volteer: Wake on AC connect and disconnect

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Abe Levkoy (Code Review)

23 Sep 2020 23 Sep '20

4:13 p.m.

Abe Levkoy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: volteer: Wake on AC connect and disconnect ......................................................................

volteer: Wake on AC connect and disconnect

Add AC connect and disconnect to S0ix lazy wake sources.

BUG=b:161466940 BRANCH=master TEST=Connect and disconnect charger in S0ix; observe wake

Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45669/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h index 1ee7ca6..1428ec8 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h @@ -34,7 +34,9 @@ /* EC can wake from S3 with lid, power button or mode change event */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))

#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Abe Levkoy (Code Review)

23 Sep 23 Sep

4:15 p.m.

Hello build bot (Jenkins), Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45669

to look at the new patch set (#2).

Change subject: volteer: Wake on AC connect and disconnect ......................................................................

volteer: Wake on AC connect and disconnect

Add AC connect and disconnect to S0ix lazy wake sources.

BUG=b:161466940 BRANCH=master TEST=Connect and disconnect charger in S0ix; observe wake

Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Signed-off-by: Abe Levkoy alevkoy@chromium.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45669/2

Tim Wawrzynczak (Code Review)

24 Sep 24 Sep

8:52 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: volteer: Wake on AC connect and disconnect ......................................................................

Patch Set 2: Code-Review+2

Looks good abe! congrats on your first CB patch!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 2 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Sep 2020 15:52:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Josie Nordrum (Code Review)

9:42 a.m.

Josie Nordrum has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: volteer: Wake on AC connect and disconnect ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45669/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45669/2//COMMIT_MSG@7 PS2, Line 7: volteer Should be mb/google/volteer

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 2 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Josie Nordrum josienordrum@google.com Gerrit-Comment-Date: Thu, 24 Sep 2020 16:42:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Abe Levkoy (Code Review)

12:24 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Wake on AC connect and disconnect

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45669

to look at the new patch set (#3).

Change subject: mb/google/volteer: Wake on AC connect and disconnect ......................................................................

mb/google/volteer: Wake on AC connect and disconnect

Add AC connect and disconnect to S0ix lazy wake sources.

BUG=b:161466940 BRANCH=master TEST=Connect and disconnect charger in S0ix; observe wake

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45669/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 3 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Josie Nordrum josienordrum@google.com Gerrit-MessageType: newpatchset

Caveh Jalali (Code Review)

5:49 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Wake on AC connect and disconnect

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: mb/google/volteer: Wake on AC connect and disconnect ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 3 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Josie Nordrum josienordrum@google.com Gerrit-Comment-Date: Fri, 25 Sep 2020 00:49:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

25 Sep 25 Sep

8:21 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Wake on AC connect and disconnect

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: mb/google/volteer: Wake on AC connect and disconnect ......................................................................

Patch Set 3:

FYI on coreboot, patches can't be submitted until all comments are marked resolved.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 3 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Josie Nordrum josienordrum@google.com Gerrit-Comment-Date: Fri, 25 Sep 2020 15:21:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Abe Levkoy (Code Review)

8:51 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Wake on AC connect and disconnect

Abe Levkoy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: mb/google/volteer: Wake on AC connect and disconnect ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45669/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45669/2//COMMIT_MSG@7 PS2, Line 7: volteer

...

Should be mb/google/volteer

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 3 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Josie Nordrum josienordrum@google.com Gerrit-Comment-Date: Fri, 25 Sep 2020 15:51:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Josie Nordrum josienordrum@google.com Gerrit-MessageType: comment

Abe Levkoy (Code Review)

3:40 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Wake on AC connect and disconnect

Abe Levkoy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: mb/google/volteer: Wake on AC connect and disconnect ......................................................................

Patch Set 3:

Tim: Can you submit this?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 3 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Josie Nordrum josienordrum@google.com Gerrit-Comment-Date: Fri, 25 Sep 2020 22:40:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

3:42 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Wake on AC connect and disconnect

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45669 )

Change subject: mb/google/volteer: Wake on AC connect and disconnect ......................................................................

mb/google/volteer: Wake on AC connect and disconnect

Add AC connect and disconnect to S0ix lazy wake sources.

BUG=b:161466940 BRANCH=master TEST=Connect and disconnect charger in S0ix; observe wake

Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Signed-off-by: Abe Levkoy alevkoy@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/45669 Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved

#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)

-- To view, visit https://review.coreboot.org/c/coreboot/+/45669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30046a379ff75c33b991e355cc8d142241ee8b2e Gerrit-Change-Number: 45669 Gerrit-PatchSet: 4 Gerrit-Owner: Abe Levkoy alevkoy@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Josie Nordrum josienordrum@google.com Gerrit-MessageType: merged

1514

days inactive

1516

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Abe Levkoy (Code Review)
Caveh Jalali (Code Review)
Josie Nordrum (Code Review)
Tim Wawrzynczak (Code Review)