Attention is currently required from: Arthur Heymans, Lance Zhao.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76293?usp=email )
Change subject: acpi.c: Find FACS using 64bit address fields
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76293/comment/09cfd053_eded3e61 :
PS2, Line 1633: | (uint64_t)fadt->x_firmware_ctl_h << 32);
For some reason, src/southbridge/amd/pi/hudson/fadt.c has this:
fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */
fadt->x_firmware_ctl_h = 0;
The only hardware using this now, pcengines/apu[2..6] do not support S3 but I think this change would break S3 resume if FACS was ever located above 4G.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76293?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I406b9b470d6e76867e47cfda427b199e20cc9b32
Gerrit-Change-Number: 76293
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 02 Aug 2023 07:00:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment