Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.
Trevor Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 )
Change subject: mb/google/cherry: Add MAX98390 support for DOJO
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/cherry/Kconfig:
https://review.coreboot.org/c/coreboot/+/63083/comment/73bc3a19_c3af738d
PS2, Line 66: BOARD_GOOGLE_CHERRY || BOARD_GOOGLE_TOMATO
what about […]
This way was discussed in RT1011 upstream.
More codec support in cherry is highly possible.
As discussed offline, we keep the expression here, because it is clear and easy for more codec support.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63083
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b6bc5a5520292dd502b0389217f5062479b4490
Gerrit-Change-Number: 63083
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Trevor Wu
trevor.wu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 25 Mar 2022 02:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment