Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Lean Sheng Tan, Naresh Solanki, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74436 )
Change subject: soc/intel/xeon_sp/spr: Add support to not sort struct device cpus for numa
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74436/comment/90db01d0_b1d2db2f
PS3, Line 8: numa
I don't understand this. Please refer to the actual change. e.g.
"Remove stale call to...". If that is the intention. And please
mention related details in the commit message (e.g. API changed
in ...).
File src/soc/intel/xeon_sp/spr/cpu.c:
https://review.coreboot.org/c/coreboot/+/74436/comment/3a793c83_1dfdfa12
PS3, Line 83: cpu->path.apic.package_id);
Is this related?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74436
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89e14b40186007ab0290b24cd6bd58015be376b6
Gerrit-Change-Number: 74436
Gerrit-PatchSet: 3
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 14 Apr 2023 12:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment