Attention is currently required from: Jakub Czapiga, Jan Dabros. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case ......................................................................
Patch Set 8:
(3 comments)
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/5f1ef881_ba5dbd39 PS7, Line 65: goto error;
If setup function exits with non-zero exit code, the teardown function is not called by CMocka. I am calling it in the error section and passing correct pointer `(void **)&s)` before returning from setup function.
Oh, you are... okay, sorry, didn't look at that closely enough.
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/23d4db1e_f69f89f3 PS8, Line 64: comp_file_suffix); Not sure why you moved these around now? You can't snprintf() into the pointer before you check it for NULL.
https://review.coreboot.org/c/coreboot/+/57555/comment/86f7156b_71caba0f PS8, Line 167: */ No, sorry, this isn't what I meant. I meant documenting what the different files 1, 2, 3, 4 are, e.g. are they text files, binaries, etc., were they compressed with different versions of lzmautils... basically, why are we testing exactly these 4 and not more or less? Each test file should have a specific purpose for being there and a notable difference from the other test cases.