Change in coreboot[master]: mb/intel/adlrvp: Configure Camera related GPIO as per schematics

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Varshit B Pandya (Code Review)

12 Nov 2020 12 Nov '20

12:13 a.m.

Varshit B Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

mb/intel/adlrvp: Configure Camera related GPIO as per schematics

Configure RST and PWR_EN signals for both WFC and UFC

Signed-off-by: Varshit Pandya varshit.b.pandya@intel.com Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec --- M src/mainboard/intel/adlrvp/gpio.c 1 file changed, 9 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47496/1

diff --git a/src/mainboard/intel/adlrvp/gpio.c b/src/mainboard/intel/adlrvp/gpio.c index 9f96620..bf1dad2 100644 --- a/src/mainboard/intel/adlrvp/gpio.c +++ b/src/mainboard/intel/adlrvp/gpio.c @@ -26,8 +26,6 @@ PAD_CFG_GPO(GPP_B2, 1, PLTRST), /* M.2 SSD_2 Reset */ PAD_CFG_GPO(GPP_H0, 1, PLTRST), - /* CAM1-IRQ */ - PAD_CFG_GPO(GPP_B23, 1, PLTRST), /* CAM_STROBE */ PAD_CFG_GPO(GPP_B18, 0, PLTRST), /* Audio Codec INT N */ @@ -182,15 +180,6 @@ /* I2S0_RXD */ PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2),

- /* I2S1_SCLK */ - PAD_CFG_NF(GPP_A23, NONE, DEEP, NF1), - /* I2S1_SFRM */ - PAD_CFG_NF(GPP_R5, NONE, DEEP, NF2), - /* I2S1_TXD */ - PAD_CFG_NF(GPP_R6, NONE, DEEP, NF2), - /* I2S1_RXD */ - PAD_CFG_NF(GPP_R7, NONE, DEEP, NF2), - /* I2S2_SCLK */ PAD_CFG_NF(GPP_A7, NONE, DEEP, NF1), /* I2S2_SFRM */ @@ -273,6 +262,15 @@ PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1), PAD_CFG_NF(GPP_H22, NONE, DEEP, NF1), PAD_CFG_NF(GPP_H23, NONE, DEEP, NF1), + + /* CAM1_RST */ + PAD_CFG_GPO(GPP_R5, 1, PLTRST), + /* CAM2_RST */ + PAD_CFG_GPO(GPP_E15, 1, PLTRST), + /* CAM1_PWR_EN */ + PAD_CFG_GPO(GPP_B23, 1, PLTRST), + /* CAM2_PWR_EN */ + PAD_CFG_GPO(GPP_E16, 1, PLTRST), };

void variant_configure_gpio_pads(void)

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

Paul Menzel (Code Review)

12 Nov 12 Nov

1:55 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 1 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Nov 2020 09:55:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Varshit B Pandya (Code Review)

13 Nov 13 Nov

3:09 a.m.

Hello V Sowmya, build bot (Jenkins), Paul Menzel, Subrata Banik, Aamir Bohra,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47496

to look at the new patch set (#2).

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

mb/intel/adlrvp: Configure Camera related GPIO as per schematics

Configure RST and PWR_EN signals for both WFC and UFC

Signed-off-by: Varshit Pandya varshit.b.pandya@intel.com Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec --- M src/mainboard/intel/adlrvp/gpio.c 1 file changed, 9 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47496/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Varshit B Pandya (Code Review)

23 Nov 23 Nov

8 p.m.

Hello V Sowmya, build bot (Jenkins), Paul Menzel, Subrata Banik, Aamir Bohra,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47496

to look at the new patch set (#3).

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

mb/intel/adlrvp: Configure Camera related GPIO as per schematics

Configure RST and PWR_EN signals for both WFC and UFC

Signed-off-by: Varshit Pandya varshit.b.pandya@intel.com Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec --- M src/mainboard/intel/adlrvp/gpio.c 1 file changed, 8 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47496/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 3 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Frans Hendriks (Code Review)

27 Nov 27 Nov

6:31 a.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 27 Nov 2020 14:31:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

9:15 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/47496/4/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/gpio.c:

https://review.coreboot.org/c/coreboot/+/47496/4/src/mainboard/intel/adlrvp/... PS4, Line 270: /* CAM1_RST */ : PAD_CFG_GPO(GPP_R5, 1, PLTRST), : /* CAM2_RST */ : PAD_CFG_GPO(GPP_E15, 1, PLTRST), : /* CAM1_PWR_EN */ : PAD_CFG_GPO(GPP_B23, 1, PLTRST), : /* CAM2_PWR_EN */ : PAD_CFG_GPO(GPP_E16, 1, PLTRST), can we move this into line #74 ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 27 Nov 2020 17:15:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Varshit B Pandya (Code Review)

11:39 a.m.

Hello V Sowmya, build bot (Jenkins), Frans Hendriks, Paul Menzel, Subrata Banik, Aamir Bohra,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47496

to look at the new patch set (#5).

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

mb/intel/adlrvp: Configure Camera related GPIO as per schematics

Configure RST and PWR_EN signals for both WFC and UFC

Signed-off-by: Varshit Pandya varshit.b.pandya@intel.com Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec --- M src/mainboard/intel/adlrvp/gpio.c 1 file changed, 8 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47496/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 5 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Varshit B Pandya (Code Review)

11:41 a.m.

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47496/4/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/gpio.c:

...

can we move this into line #74 ?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 5 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 27 Nov 2020 19:41:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

11:41 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

Patch Set 5:

(11 comments)

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/gpio.c:

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 75: PAD_CFG_GPO(GPP_R5, 1, PLTRST), code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 75: PAD_CFG_GPO(GPP_R5, 1, PLTRST), please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 76: /* CAM2_RST */ code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 77: PAD_CFG_GPO(GPP_E15, 1, PLTRST), code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 77: PAD_CFG_GPO(GPP_E15, 1, PLTRST), please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 78: /* CAM1_PWR_EN */ code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 79: PAD_CFG_GPO(GPP_B23, 1, PLTRST), code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 79: PAD_CFG_GPO(GPP_B23, 1, PLTRST), please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 80: /* CAM2_PWR_EN */ code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 81: PAD_CFG_GPO(GPP_E16, 1, PLTRST), code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/47496/5/src/mainboard/intel/adlrvp/... PS5, Line 81: PAD_CFG_GPO(GPP_E16, 1, PLTRST), please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 5 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 27 Nov 2020 19:41:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Varshit B Pandya (Code Review)

11:46 a.m.

Hello V Sowmya, build bot (Jenkins), Frans Hendriks, Paul Menzel, Subrata Banik, Aamir Bohra,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47496

to look at the new patch set (#6).

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

mb/intel/adlrvp: Configure Camera related GPIO as per schematics

Configure RST and PWR_EN signals for both WFC and UFC

Signed-off-by: Varshit Pandya varshit.b.pandya@intel.com Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec --- M src/mainboard/intel/adlrvp/gpio.c 1 file changed, 8 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47496/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 6 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

7:56 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 6 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 28 Nov 2020 03:56:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

V Sowmya (Code Review)

30 Nov 30 Nov

1:12 a.m.

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 7 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 30 Nov 2020 09:12:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

11:59 p.m.

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47496 )

Change subject: mb/intel/adlrvp: Configure Camera related GPIO as per schematics ......................................................................

mb/intel/adlrvp: Configure Camera related GPIO as per schematics

Configure RST and PWR_EN signals for both WFC and UFC

Signed-off-by: Varshit Pandya varshit.b.pandya@intel.com Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Reviewed-on: https://review.coreboot.org/c/coreboot/+/47496 Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/adlrvp/gpio.c 1 file changed, 8 insertions(+), 11 deletions(-)

Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved V Sowmya: Looks good to me, approved

diff --git a/src/mainboard/intel/adlrvp/gpio.c b/src/mainboard/intel/adlrvp/gpio.c index 9b94cec..8ff6fcd 100644 --- a/src/mainboard/intel/adlrvp/gpio.c +++ b/src/mainboard/intel/adlrvp/gpio.c @@ -26,8 +26,6 @@ PAD_CFG_GPO(GPP_B2, 1, PLTRST), /* M.2 SSD_2 Reset */ PAD_CFG_GPO(GPP_H0, 1, PLTRST), - /* CAM1-IRQ */ - PAD_CFG_GPO(GPP_B23, 1, PLTRST), /* CAM_STROBE */ PAD_CFG_GPO(GPP_B18, 0, PLTRST), /* Audio Codec INT N */ @@ -77,6 +75,14 @@ /* SRCCLK_OEB6 */ PAD_CFG_GPO(GPP_E5, 0, PLTRST),

+ /* CAM1_RST */ + PAD_CFG_GPO(GPP_R5, 1, PLTRST), + /* CAM2_RST */ + PAD_CFG_GPO(GPP_E15, 1, PLTRST), + /* CAM1_PWR_EN */ + PAD_CFG_GPO(GPP_B23, 1, PLTRST), + /* CAM2_PWR_EN */ + PAD_CFG_GPO(GPP_E16, 1, PLTRST), /* M.2_SSD_PDET_R */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* THC0 SPI1 CLK */ @@ -186,15 +192,6 @@ /* I2S0_RXD */ PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2),

-- To view, visit https://review.coreboot.org/c/coreboot/+/47496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie416da373756b1c73472b8572f87930965a3d6ec Gerrit-Change-Number: 47496 Gerrit-PatchSet: 8 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1446

days inactive

1465

days old

coreboot-gerrit@coreboot.org

12 comments

6 participants

tags (0)

participants (6)

build bot (Jenkins) (Code Review)
Frans Hendriks (Code Review)
Paul Menzel (Code Review)
Subrata Banik (Code Review)
V Sowmya (Code Review)
Varshit B Pandya (Code Review)