Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device defintions to pci_devs.h ......................................................................
soc/intel/skylake: Add PEG device defintions to pci_devs.h
Change-Id: Ib2453425f44e2b4abd5566f454ae68b704dbc33e Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/skylake/include/soc/pci_devs.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/44366/1
diff --git a/src/soc/intel/skylake/include/soc/pci_devs.h b/src/soc/intel/skylake/include/soc/pci_devs.h index 7838c20..319a12b 100644 --- a/src/soc/intel/skylake/include/soc/pci_devs.h +++ b/src/soc/intel/skylake/include/soc/pci_devs.h @@ -23,6 +23,12 @@ #endif
#define SA_DEV_SLOT_PEG 0x01 +#define SA_DEVFN_PEG0 PCI_DEVFN(SA_DEV_SLOT_PEG, 0) +#define SA_DEVFN_PEG1 PCI_DEVFN(SA_DEV_SLOT_PEG, 1) +#define SA_DEVFN_PEG2 PCI_DEVFN(SA_DEV_SLOT_PEG, 2) +#define SA_DEV_PEG0 PCI_DEV(0, SA_DEV_SLOT_PEG, 0) +#define SA_DEV_PEG1 PCI_DEV(0, SA_DEV_SLOT_PEG, 1) +#define SA_DEV_PEG2 PCI_DEV(0, SA_DEV_SLOT_PEG, 2)
#define SA_DEV_SLOT_IGD 0x02 #define SA_DEVFN_IGD PCI_DEVFN(SA_DEV_SLOT_IGD, 0)
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44366
to look at the new patch set (#2).
Change subject: soc/intel/skylake: Add PEG device defintions to pci_devs.h ......................................................................
soc/intel/skylake: Add PEG device defintions to pci_devs.h
Change-Id: Ib2453425f44e2b4abd5566f454ae68b704dbc33e Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/skylake/include/soc/pci_devs.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/44366/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device defintions to pci_devs.h ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device defintions to pci_devs.h ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device defintions to pci_devs.h ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Would be nice to guard these so that we don't use them on LP SKUs
https://review.coreboot.org/c/coreboot/+/44366/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44366/3//COMMIT_MSG@7 PS3, Line 7: defintions defin*i*tions
Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44366
to look at the new patch set (#4).
Change subject: soc/intel/skylake: Add PEG device definitions to pci_devs.h ......................................................................
soc/intel/skylake: Add PEG device definitions to pci_devs.h
Change-Id: Ib2453425f44e2b4abd5566f454ae68b704dbc33e Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/skylake/include/soc/pci_devs.h 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/44366/4
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device definitions to pci_devs.h ......................................................................
Patch Set 4:
(1 comment)
Would be nice to guard these so that we don't use them on LP SKUs
Good idea. Will do this in another patch, since we also need to guard soc_peg_init_params() then.
https://review.coreboot.org/c/coreboot/+/44366/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44366/3//COMMIT_MSG@7 PS3, Line 7: defintions
defin*i*tions
Done
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device definitions to pci_devs.h ......................................................................
Patch Set 5: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device definitions to pci_devs.h ......................................................................
soc/intel/skylake: Add PEG device definitions to pci_devs.h
Change-Id: Ib2453425f44e2b4abd5566f454ae68b704dbc33e Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/44366 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/soc/intel/skylake/include/soc/pci_devs.h 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/soc/intel/skylake/include/soc/pci_devs.h b/src/soc/intel/skylake/include/soc/pci_devs.h index 7838c20..319a12b 100644 --- a/src/soc/intel/skylake/include/soc/pci_devs.h +++ b/src/soc/intel/skylake/include/soc/pci_devs.h @@ -23,6 +23,12 @@ #endif
#define SA_DEV_SLOT_PEG 0x01 +#define SA_DEVFN_PEG0 PCI_DEVFN(SA_DEV_SLOT_PEG, 0) +#define SA_DEVFN_PEG1 PCI_DEVFN(SA_DEV_SLOT_PEG, 1) +#define SA_DEVFN_PEG2 PCI_DEVFN(SA_DEV_SLOT_PEG, 2) +#define SA_DEV_PEG0 PCI_DEV(0, SA_DEV_SLOT_PEG, 0) +#define SA_DEV_PEG1 PCI_DEV(0, SA_DEV_SLOT_PEG, 1) +#define SA_DEV_PEG2 PCI_DEV(0, SA_DEV_SLOT_PEG, 2)
#define SA_DEV_SLOT_IGD 0x02 #define SA_DEVFN_IGD PCI_DEVFN(SA_DEV_SLOT_IGD, 0)
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Michael Niewöhner (Code Review)
-
Paul Menzel (Code Review)