Attention is currently required from: Rex-BC Chen, Trevor Wu, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 )
Change subject: mb/google/cherry: Add MAX98390 support for DOJO
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/cherry/Kconfig:
https://review.coreboot.org/c/coreboot/+/63083/comment/e5e79a73_1def99e9
PS2, Line 66: BOARD_GOOGLE_CHERRY || BOARD_GOOGLE_TOMATO
This way was discussed in RT1011 upstream. […]
Ack
File src/mainboard/google/cherry/chromeos.c:
https://review.coreboot.org/c/coreboot/+/63083/comment/f9e8cbbd_e8478614
PS2, Line 60:
We should list the supported codec.
else if (CONFIG(CHERRY_USE_MAX98390))
...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63083
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b6bc5a5520292dd502b0389217f5062479b4490
Gerrit-Change-Number: 63083
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Trevor Wu
trevor.wu@mediatek.corp-partner.google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Trevor Wu
trevor.wu@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 25 Mar 2022 03:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Trevor Wu
trevor.wu@mediatek.corp-partner.google.com
Gerrit-MessageType: comment