Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Zheng Bao.
Marshall Dawson has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84195?usp=email )
Change subject: cezanne: Add recovery AB support option ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84195/comment/f22fd148_692ab078?usp... : PS1, Line 9: Non A/B recovery This would simply be no recovery method, right? (Although vboot is an alternative methodology.) Also, I'd mention that details of A/B recovery are in the NDA spec #56995.
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/84195/comment/2e1f08d8_1c4044d9?usp... : PS1, Line 412: "Recovery A/B" maybe "Use A/B Recovery scheme"?
https://review.coreboot.org/c/coreboot/+/84195/comment/c429b1d9_f93e6e5b?usp... : PS1, Line 415: Recovery A/B How about "Enable the PSP A/B Recovery mechanism"? Also, should we put some words in here about vboot? I think we'd probably recommend not using with vboot although I suspect they could coexist in the image.
-
Marshall Dawson (Code Review)