Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support with interface tables ......................................................................
Patch Set 32:
(3 comments)
https://review.coreboot.org/#/c/29967/30/src/mainboard/google/mistral/Makefi... File src/mainboard/google/mistral/Makefile.inc:
https://review.coreboot.org/#/c/29967/30/src/mainboard/google/mistral/Makefi... PS30, Line 16: romstage-y += romstage.c
duplicate line?
Done
https://review.coreboot.org/#/c/29967/30/src/mainboard/google/mistral/romsta... File src/mainboard/google/mistral/romstage.c:
https://review.coreboot.org/#/c/29967/30/src/mainboard/google/mistral/romsta... PS30, Line 32: qclib_load_and_run();
Normally this should be the last call in this function.
Done
https://review.coreboot.org/#/c/29967/30/src/soc/qualcomm/qcs405/include/soc... File src/soc/qualcomm/qcs405/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/29967/30/src/soc/qualcomm/qcs405/include/soc... PS30, Line 45: 0x1000
please pick one style and use it (given everything else, 4096?). […]
Done
-
Patrick Georgi (Code Review)