Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83411?usp=email )
Change subject: mb/google/drallion: Don't enable DPTF PCI device
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83411/comment/12f3fa34_27f01198?usp... :
PS1, Line 49: register "Device4Enable" = "1"
that doesn't really matter, the PCI device being enabled isn't the issue, just the duplicate ACPI de […]
Then it might be better find the source for the issue. I'm about to hook up the Device4Enable option to the devicetree, which requires to turn on the PCI device.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83411?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0e07d9d64c543121aa51a7cfd63fe3686192825
Gerrit-Change-Number: 83411
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Fri, 12 Jul 2024 20:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com