Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: vc/google/chromeos: Add support for new SAR tables revisions ......................................................................
Patch Set 17:
(1 comment)
File src/include/sar.h:
https://review.coreboot.org/c/coreboot/+/56750/comment/e76738b9_796635f7 PS17, Line 21: struct wifi_sar_delta_table { : uint8_t version; : union { : struct { : uint8_t power_max_2400mhz; : uint8_t power_chain_a_2400mhz; : uint8_t power_chain_b_2400mhz; : uint8_t power_max_5200mhz; : uint8_t power_chain_a_5200mhz; : uint8_t power_chain_b_5200mhz; : } __packed group_rev0[SAR_NUM_WGDS_GROUPS]; : struct { : uint8_t power_max_2400mhz; : uint8_t power_chain_a_2400mhz; : uint8_t power_chain_b_2400mhz; : uint8_t power_max_5200mhz; : uint8_t power_chain_a_5200mhz; : uint8_t power_chain_b_5200mhz; : uint8_t power_max_6000mhz; : uint8_t power_chain_a_6000mhz; : uint8_t power_chain_b_6000mhz; : } __packed group_rev1[SAR_NUM_WGDS_GROUPS]; : } __packed; : } __packed;
This think this will be better approach. […]
Thanks Sugnan. Before you go ahead with the changes, let's just wait one more day to see if Tim has any other comments as well. Don't want to make you go back and forth between different implementations :). Thanks!