Attention is currently required from: Felix Singer, Michael Niewöhner, Ron Minnich.
Nicholas Sudsgaard has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80470?usp=email )
Change subject: util: Add hda-decoder
......................................................................
Patch Set 8:
(3 comments)
This change is ready for review.
Patchset:
PS4:
Holding this change off until CB:80695.
Took a while but I finally got around updating this utility.
File util/hda-decoder/go.mod:
https://review.coreboot.org/c/coreboot/+/80470/comment/7f81a09c_8cb9f52d?usp... :
PS4, Line 1: module review.coreboot.org/coreboot.git/util/hda-decoder
not a Go expert as well, but I looked around. […]
Marking as resolved.
File util/hda-decoder/main.go:
https://review.coreboot.org/c/coreboot/+/80470/comment/8dfeea1f_a3f17493?usp... :
PS4, Line 13: "review.coreboot.org/coreboot.git/util/hda-decoder/decoder"
Same here
Marking as resolved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80470?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4fb652e178517b2b7aceaac8be005c5b2d3b03e
Gerrit-Change-Number: 80470
Gerrit-PatchSet: 8
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sat, 13 Jul 2024 05:09:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de